docs(extension): address review feedback on #118 #123

Merged

synath merged 0 commits from refs/pull/123/head into main

2026-05-08 05:31:14 +00:00

synath commented

2026-05-08 03:24:12 +00:00

(Migrated from codeberg.org)

Summary

Two small follow-ups from your review of #118:

Bumped PROTOCOL_VERSION in extension/test_smoke.py from 2024-11-05 to 2025-06-18. mcp-go v0.44.0 has version-negotiation tests covering both, so the bump is safe; 2025-06-18 matches the current MCP spec version you mentioned.
Rewrote Option A in extension/README.md so it no longer points to a regenerator script that "lives in commit history" — the script was never committed. New text points to test_smoke.py as the starting reference for the MCP handshake instead.

Friction note

While I was in the file: the "Possible follow-ups" section in extension/README.md now starts with two items you shipped in #122 (goreleaser hook + per-platform packaging). I left them alone to keep this PR scoped to your review feedback — happy to clean those up in a separate small PR if useful.

What I didn't address from the review

Smoke-test SKIPs in CI without a token — flagged this as a CI/secrets decision that's yours to make rather than something to push unilaterally.
Tool description drift — leaving for the first time it actually bites; the smoke test's name set-equality already catches the most likely failure mode.

Glad to take either on if you'd like — just say the word.

Test plan

python3 extension/test_smoke.py runs cleanly (SKIPs without FORGEJO_ACCESS_TOKEN, the existing CI-friendly behavior).
Verified mcp-go v0.44.0 explicitly supports 2025-06-18 (server/version_test.go has it as a tested client version).
make build clean.

## Summary Two small follow-ups from your review of #118: - Bumped `PROTOCOL_VERSION` in `extension/test_smoke.py` from `2024-11-05` to `2025-06-18`. mcp-go v0.44.0 has version-negotiation tests covering both, so the bump is safe; `2025-06-18` matches the current MCP spec version you mentioned. - Rewrote Option A in `extension/README.md` so it no longer points to a regenerator script that "lives in commit history" — the script was never committed. New text points to `test_smoke.py` as the starting reference for the MCP handshake instead. ## Friction note While I was in the file: the "Possible follow-ups" section in `extension/README.md` now starts with two items you shipped in #122 (goreleaser hook + per-platform packaging). I left them alone to keep this PR scoped to your review feedback — happy to clean those up in a separate small PR if useful. ## What I didn't address from the review - **Smoke-test SKIPs in CI without a token** — flagged this as a CI/secrets decision that's yours to make rather than something to push unilaterally. - **Tool description drift** — leaving for the first time it actually bites; the smoke test's name set-equality already catches the most likely failure mode. Glad to take either on if you'd like — just say the word. ## Test plan - [x] `python3 extension/test_smoke.py` runs cleanly (SKIPs without `FORGEJO_ACCESS_TOKEN`, the existing CI-friendly behavior). - [x] Verified mcp-go v0.44.0 explicitly supports `2025-06-18` (`server/version_test.go` has it as a tested client version). - [x] `make build` clean.

goern commented

2026-05-08 05:31:02 +00:00

(Migrated from codeberg.org)

Thanks for the cleanup!

synath commented

2026-05-08 05:52:45 +00:00

(Migrated from codeberg.org)

Happy to help! Thanks for making the MCP!

No reviewers

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference

agentic-forges/forgejo-mcp!123

No description provided.

Rows
Columns